Jack Schwartz wrote:
> Hi everyone.
> 
> Please review the following one-liner that fixes accessibility in USB 
> stick grub menus.
> 
> http://cr.opensolaris.org/~schwartz/081112.1/webrev
> 
> Basically, the fix is to change from:
>    deleting everything beyond and including the line which says "Hard Disk"
> to
>    deleting the grub entry for the Hard Disk (from the "Hard Disk" line 
> to the first blank
>    line afterward.
> 

It's correct, but fragile.  Really, it should delete from a line with 
that title to the next title.  I guess I'd take it as-is, but I'd feel 
better if it weren't going to require a future fix when the menu gets 
generated differently.

> I'll push as soon as I have two satisfied reviewers or 2 PM PST today, 
> whichever is later.
> 

The latter isn't an option, must have reviewers.

Dave

Reply via email to