Karen Tung wrote: > Hi Ethan, > > Your changes look good to me. > > Just 1 nit: > > Why do you need to assign "fp" to NULL in line 637? Since fp > is not used anymore, I think we can save that 1 statement.
I can remove that. thanks, -ethan > > Thanks, > > --Karen > > Ethan Quach wrote: >> Need a review for this blocker >> >> >> Webrev: >> ------ >> http://cr.opensolaris.org/~equach/webrev.4894 >> >> Defect: >> ------ >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4894 >> >> >> The fix has been tested by the IPS GUI team, and they've >> verified that it fixes their issue with updatemanager >> and packagemanager. >> >> I've also done regressions tests on it where: >> >> 1. pool has no capability file >> 2. pool has capability file and has a smaller version, >> so grub needed to be updated. >> 3. pool has capability file and does not have a smaller >> version, so grub didn't not need to be updated. >> >> >> >> thanks, >> -ethan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >
