Tim Knitter wrote:
>
>
> Jan Damborsky wrote:
>> Hi Tim,
>>
>>
>> Tim Knitter wrote:
>>> Hi Jan,
>>>
>>> Nit:
>>>
>>> This sentence could be clearer and less vague.
>>>
>>> 141 * (committed_disk_target == NULL), it
>>> 142 * is necessary to create copy of
>>> 143 * original partition configuration now
>>> 144 * and change the partition type there
>>>
>>> Suggest simplifying:
>>>
>>> * (committed_disk_target == NULL), it
>>> * is necessary to create a copy of the
>>> * original partition configuration and
>>> * change the partition type.
>>
>> Done.
>>
>>>
>>>
>>> 159 if (committed_disk_target == NULL) {
>>> 160 om_set_error(OM_NO_SPACE);
>>>
>>> Wouldn't it be better to check one of the disk_info members as well
>>> as "committed_disk_target == NULL" here before setting a ON_NO_SPACE
>>> message?
>>
>> Based on Dave's comment, check for return value from
>> om_set_disk_partition_info() was added - it covers
>> check for NULL above and other potential failures.
>
> ok.
>
>>
>> I have posted updated webrev at the same location.
>> Could you please take a look and let me know,
>> if you think that those changes might cover your
>> suggestion ?
>>
>> Thank you very much for review !
>
> Your welcome Jan. Looks fine.
Thanks a lot !
Jan
>
> Tim
>
>> Jan
>>
>>
>>> Thanks
>>> Tim
>>>
>>> jan damborsky wrote:
>>>> Hi Dave,
>>>>
>>>> based on the yesterday's discussion during Caiman meeting,
>>>> I am assuming that following bug is to be qualified as
>>>> 2008.11 stopper. This fix addresses scenario Rafal
>>>> reported in bug 4872.
>>>>
>>>> Could you please let me know, if my understanding is correct ?
>>>>
>>>> If this is the case, could I please ask two people to review
>>>> those changes ?
>>>>
>>>> 4980 Installer should convert legacy Solaris partition (0x82) to
>>>> Solaris2 one (0xbf)
>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4980
>>>>
>>>> The webrev is available at:
>>>> http://cr.opensolaris.org/~dambi/bug-4980
>>>>
>>>> Thank you,
>>>> Jan
>>>>
>>>> Modules affected:
>>>> -----------------
>>>> * liborchestrator
>>>>
>>>> Testing done:
>>>> -------------
>>>> configuration:
>>>> * HW: vmware guest (1GB RWM) on Linux host
>>>> * SW: LiveCD installation based on osol-0811-101a-rc1b.iso
>>>> * original partition configuration (before installation):
>>>> * Id Act Bhead Bsect Bcyl Ehead Esect Ecyl Rsect
>>>> Numsect
>>>> 192 0 0 1 1 254 63 1023
>>>> 16065 22491000
>>>> 130 0 254 63 1023 254 63 1023
>>>> 22507065 29988864
>>>> 130 0 254 63 1023 254 63 1023
>>>> 52500420 4192965
>>>>
>>>> * On installer 'Disk screen' partitions are identified as:
>>>> Unknown 10.7
>>>> Solaris 14.3
>>>> Linux swap 2.0
>>>> Unused 0.0
>>>>
>>>> [1] Without fix
>>>> ---------------
>>>> * installer didn't change legacy Solaris partition to new one
>>>> * both 0x82 partitions were marked as 'active':
>>>> * Id Act Bhead Bsect Bcyl Ehead Esect Ecyl Rsect
>>>> Numsect
>>>> 192 0 0 1 1 254 63 1023
>>>> 16065 22491000
>>>> 130 128 254 63 1023 254 63 1023
>>>> 22507065 29988864
>>>> 130 128 254 63 1023 254 63 1023
>>>> 52500420 4192965
>>>>
>>>> * installer hung during "bootadm update-menu -R /a -Z -O
>>>> /dev/rdsk/c3d0s0"
>>>>
>>>> [2] With fix
>>>> ------------
>>>> * installer changed legacy Solaris partition to new one (0xbf)
>>>> * only 0xbf partition was marked as 'active':
>>>> * Id Act Bhead Bsect Bcyl Ehead Esect Ecyl Rsect
>>>> Numsect
>>>> 192 0 0 1 1 254 63 1023
>>>> 16065 22491000
>>>> 191 128 254 63 1023 254 63 1023
>>>> 22507065 29988864
>>>> 130 0 254 63 1023 254 63 1023
>>>> 52500420 4192965
>>>>
>>>> * installer didn't hang and installed Solaris was successfully booted
>>>>
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
