Thanks Dave.
Dave Miner wrote: > Joseph J VLcek wrote: >> Hello, >> >> Can two people please do a code review for bug: >> >> 4673 Grub text only mode is required >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4673 >> >> >> The webrev is available at: >> http://cr.opensolaris.org/~joev/bug4673/ >> > > General comment: bootadm delimits individual entries with the "ADDED BY > BOOTADM" / "END BOOTADM" comment pairs. You should just add the new > entry after that, not encapsulated with the bootadm markers. OK. > > 948,1025: don't need multiple levels of try I had checked with Jack S. on this he told me that to use finally with Python v2.4 the extra level is needed. I get errors without it. Using my standalone test program without the extra try level I get: opensolaris > ./modify_grub.py File "./modify_grub.py", line 132 finally: ^ SyntaxError: invalid syntax Jack sent me this example: ------------------------- python 2.4 try: try: do something risky except Exception: handle the consequences finally: always do this python 2.5: try: do something risky except Exception: handle the consequences finally: always do this > 1013: replace loop with just all.extend(one_entry) Don't want to sound nerdy but "that's very cool ;)" thanks! > > 1030: writing, not reading oops... > > 1040: doesn't appear you can get here with op == None, as you return at > 1023. Line 1023 executes only if the open for write fails. Line 1040 is executed if the open succeeds. Thanks. Joe > > Dave > >> This fix involves a rewrite of ICT enable_happy_face_boot >> >> I also fixed some begin and end comment block issues that were causing >> vim to display some of the code in the color of a comment. >> >> * The modules affected and tested: >> >> ict.py >> >> * Testing done on logic >> >> I wrote a stand alone wrapper around the changes so they could be >> exercised outside of an installation environment. >> >> I tested: >> >> - a menu.lst file with multiple entries >> - a menu.lst file with a single entry >> - a menu.lst file with embedded comments >> - a non-existing menu.lst file, reports an error >> - a read only menu.lst files, reports an error >> >> * Testing done for GUI Install >> >> I booted a 101 live Image and used mount -F lofs to applied the >> updated version of ict.py >> >> After the installation I performed reboots selecting the default >> before the timeout, I let the timeout select the default and I >> selected the text boot entry >> >> * Results: >> >> The installation completed successfully and the menu.lst file >> contained the default graphical boot entry and a second, text boot >> entry and both entries provide the expected behavior. >> >> * Testing done for AI >> >> No AI testing was performed. >> >> >> Thank you, >> Joe >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
