The updated webrev looks good. Thanks for the explanation about the ICT. --Karen
Glenn Lagasse wrote: > Hi Karen, > > * Karen Tung (Karen.Tung at Sun.COM) wrote: > >> Glenn Lagasse wrote: >> >>> All, >>> >>> Could I get two reviewers for the following blocker bugs for 2008.11? >>> Sooner is better ;-) >>> >>> CR's: >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3597 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4667 >>> >>> Webrev: >>> >>> http://cr.opensolaris.org/~glagasse/slim_3597_4667/ >>> >>> Thanks! >>> >>> >>> >> Hi Glenn, >> >> slimcd_pre_bootroot_pkg_image_mod: >> >> - The 2 files created in TMP_DIR as a result of the sed command should >> be removed >> after it is coped. >> > > Done. > > >> - You saved all those files to be restored by ICT module, but I don't >> the ICT module included in the webrev. >> > > Right, there aren't any changes required in the ICT module. The > mechanism that does the restore 'just handles it'. > > I've updated the webrev, can you verify that the changes to > slimcd_pre_bootroot_pkg_image_mod look ok? > > Thanks! > > Glenn >
