Hi Sundar.
On 11/14/08 14:17, Sundar Yamunachari wrote:
> Jack Schwartz wrote:
>> Hi Sundar.
>>
>> Here are my comments:
>>
>> usr/src/cmd/installadm/Makefile:
>>
>> 100: Seems strange to me to depend on SUBDIRS which has only
>> documentation at this point, before removing programs and scripts.
>> Can you please explain this?
> The Makefile under installadm is generic, it should traverse
> subdirectories and perform the same action. Currently docs doesn't do
> anything.
It seemed that if clean is going to depend on the contents being
cleaned, then the action should do clean the contents. But, I'll go
with the "generic" argument.
>>
>> Otherwise, things look OK to me. Have you tried installing a package
>> and verifying that the documentation works?
> See the testing section below. I verified that the package is fine,
> installed and tested it.
Oops. OK.
Thanks for following up.
Thanks,
Jack
>
> Thanks,
> Sundar
>>
>>
>> Thanks,
>> Jack
>>
>>
>> On 11/14/08 12:05, Sundar Yamunachari wrote:
>>> Hi,
>>>
>>> Please review the following fixes to integrate AI documentation to
>>> the SUNWInstalladm package. Most of the files are delivered by
>>> documentation. Please review Makefile changes and prototype changes.
>>>
>>> The webrev is at: http://cr.opensolaris.org/~ysundar/4552
>>>
>>> 4552 Add AI documentation to SUNWinstalladm-tools
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4552
>>>
>>> 4905 SUNWinstalladm-tools needs a better NAME
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4905
>>>
>>>
>>>
>>> Testing:
>>>
>>> 1. Build the package SUNWinstalladm-tools with the changes
>>> 2. Test the package with the integration tool
>>> kumbam% cd
>>> /net/indiana-build.central//export/home/sundar/sundar_ai/nov14/slim_source/packages/i386/nightly-nd/
>>>
>>>
>>> kumbam% /net/paradise.sfbay/export/tools/bin/integrate -l install -r
>>> nv_osol0811 -n SUNWinstalladm-tools
>>> ##############################################################################
>>>
>>>
>>>
>>> (TEST MODE ONLY) Integrating Package 'SUNWinstalladm-tools' to
>>> nv_osol0811 ...
>>>
>>> Sending item information to server for verification ...
>>>
>>> WARNING:Depend_PKG_MustExistInRelease:nv/SUNWinstalladm-tools(i386):
>>> nv/missing_depend_pkg=SUNWpython-cherrypy # PKG must exist in release
>>>
>>>
>>>
>>> STATUS = PASSED (Test mode only, no item is integrated)
>>>
>>> ##############################################################################
>>>
>>>
>>>
>>> See http://spgweb.sfbay/SPE/SRE/Tools/re_audits.html for audit help.
>>>
>>> 3. Install the package on a test machine. The installation is
>>> successful with out any errors.
>>> 4. Accessed the documentation. Checked all links and there are no
>>> errors.
>>>
>>> Thanks,
>>> Sundar
>>>
>>> _______________________________________________
>>> caiman-discuss mailing list
>>> caiman-discuss at opensolaris.org
>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>
>>
>
