Joerg.Schilling at Sun.COM (Joerg Schilling) wrote:

> Hi Moinak,
>
> as we touched this comment:
>
> /*
>  * Some cd writers don't write sectors that aren't
>  * used. Also, there's no point in reading sectors
>  * we'll never look at.  So, if we're asked to go
>  * beyond the end of a file, truncate to the length
>  * of that file.
>  *
>  * Additionally, this behaviour is required by section
>  * 6.4.5 of ISO 9660:1988(E).
>  */
>
> it should be updated to be more correct, e.g.:
>
> /*
>  * Some CD writers (e.g. Kodak Photo CD writers) 
>  * create CDs in TAO mode and reserve tracks that
>  * are not completely written. Some sectors remain
>  * unreadable for this reason and give I/O errors.
>  * Also, there's no point in reading sectors
>  * we'll never look at.  So, if we're asked to go
>  * beyond the end of a file, truncate to the length
>  * of that file.
>  *
>  * Additionally, this behaviour is required by section
>  * 6.4.5 of ISO 9660:1988(E).
>  */

Hi Moinak, 

I am now ready with the review and I cannot find things that
look bad anymore. For me it looks OK now and you could integrate it.

Could you please comment my mail about the wish for modifying the comment 
above? 

J?rg

-- 
 EMail:joerg at schily.isdn.cs.tu-berlin.de (home) J?rg Schilling D-13353 Berlin
       js at cs.tu-berlin.de                (uni)  
       schilling at fokus.fraunhofer.de     (work) Blog: 
http://schily.blogspot.com/
 URL:  http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily

Reply via email to