Sarah Jelinek wrote:
> Located at:
>
> http://cr.opensolaris.org/~sjelinek/slim/
>
> Are the changes to modify the installed grub menu.lst file to reflect
> the name for the October release. Please review and send comments.
> + # Modify title to reflect Indiana naming.
> + sed "s#^title.*#title Project Indiana Developer Preview#" \
> + $MENUFILE > $MENUFILE.new
Erm, please add quotes around "$MENUFILE" and use "${MENUFILE}.new" -
otherwise it's ambigous whether you mean the variable "MENUFILE" or
"MENUFILE.new" (for shells which support compound variables (compound
variables use '.' as part of a variable name)).
> + if [ "$?" -eq 0 ]; then
Please use "(( $? == 0 ))", e.g. math expressions instead of the string
operator (this should work for ksh88, ksh93 and bash). AFAI it should
then look like this:
-- snip --
if (( $? == 0 )) ; then
-- snip --
> + cat $MENUFILE.new > $MENUFILE
Please use quotes (and see comment above about the problem with '.' in
variable names), e.g. $ cat "${MENUFILE].new" > "$MENUFILE" #
> + else
> + echo "Failure in resetting Project Indiana grub entry"
> + fi
> + rm $MENUFILE.new
Quotes (and the curly branches (or whatever their names is)), please...
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 7950090
(;O/ \/ \O;)
