Jean McCormack wrote:
> 
> http://cr.opensolaris.org/~jeanm/distro_constructor/

Only a quick look at
http://cr.opensolaris.org/~jeanm/distro_constructor/distro_constructor.patch
...

> --- old/src/build_dist.bash   Thu Oct 25 11:01:00 2007
> +++ new/src/build_dist.bash   Thu Oct 25 11:01:00 2007
> @@ -123,6 +123,12 @@
>       echo "FAILURE: Error in untarring $DIST_MICROROOT_MOD"
>       fatal_exit      
>  fi
> +
> +#
> +# Append a list of the binaries to the README file
> +#
> +cd $DIST_PROTO; find . -type f -print >>README
> +
>  # This needs to be changed so it's not hardcoded.
>  POST_PROCESS_SCRIPT=post_process
>  #Make sure the post-process script is there
> @@ -146,7 +152,6 @@
>  
>  rm -rf $MICROROOT
>   
> -rm ${TMPDIR}/x86.microroot.gz
>  gzip -f ${TMPDIR}/x86.microroot

Quotes around "${TMPDIR}/x86.microroot" would be nice...

... and what about using $ set -o errexit # to stop the script (or
subshell/function) when the "gzip" or something else in the chain fails
(to avoid that ${$BOOT_ARCHIVE} gets "nuked" with an empty file) ?

>  mv ${TMPDIR}/x86.microroot.gz $BOOT_ARCHIVE

Quotes, please

>  chmod a+r $BOOT_ARCHIVE


----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)

Reply via email to