Karen Tung wrote: > This code review fixed 2 things: > > 1) After the removal of the previous slimcd_post_processing.tar and moving > code around. The mkrepo script can no longer read the generic_live.xml file > because it can't find it in "./". The full path to the generic_live.xml > file > need to be passed into mkrepo. > > 2) When some of the gnome postinstall scripts fail, all the output are > re-directed to /dev/null. This makes debugging the failures difficult. > Change it to redirect output from postinstall scripts to a file. If the > script failed, content of that file will be displayed. >
Generally I'd suggest the temporary output redirection go to something like /tmp/postrun.output.$$ so you're not dependent on write access to the current directory. Also, sending the error output you're cat'ing at 19 in exec_postrun to stderr would allow for whatever's calling it to more easily discern it as error output. Dave
