Hi Moinak,

699:
Calling strlcpy() might be avoided here, since tmpenv is
being set to constant string.

646:
Could be changed to something like

static char *tmpenv = "TMPDIR=/tmp";


Best regards,
Jan 


Moinak Ghosh wrote:
> Hi,
>
>    I have made some more changes to libtransfer:
>
> Handle zero-length files to avoid hardlink problems when copying from hsfs
>    A separate list is created for all zero length files to avoid passing
>    these pathnames to cpio. A separate loop is then used to create
>    these files onn the harddisk.
>
> Add couple of flushes to sync buferred file data for ease of debugging
> Make cpio use /tmp instead of /var/tmp to avoid filling up the ramdisk
>    TMPDIR env var is being set to /tmp to force cpio to use swap. cpio uses
>    /var/tmp by default and /var/tmp is not mounted on swap.
>
> The webrevs are at:
>
> http://jurassic.eng/~mg147109/libtransfer/webrev/
>
> I was able to get a successful boot off harddisk without any sharetab or
> utmpx errors after using this library with a DC iso image.
>
> Regards,
> Moinak.
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>   


Reply via email to