Sarah Jelinek wrote:
> 
> I have updated the install-finish script per Roland's review comments.
> Webrev is located at:
> 
> http://cr.opensolaris.org/~sjelinek/slim/

Erm...
-- snip --
+if [ $? == 0 ]; then
-- snip --
... should be ...
-- snip --
if (( $? == 0 )); then
-- snip --

The (( expression )) stuff is for mathematical expressions (see my
previous bickering about efficency of "arithmetric expressins vs. test
builtin)), e.g. stuff like (( x=sin(y)+0.5 )) or (( x > y )) (ksh88 has
only integer math while ksh93 comes with full floating-point support,
including [+/-]Infinite and [+/-]NaN).

----

Bye,
Roland

-- 
  __ .  . __
 (o.\ \/ /.o) roland.mainz at nrubsig.org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 7950090
 (;O/ \/ \O;)

Reply via email to