Virginia Wray wrote: > Hi Dave - > > Thank you for the code review. See my responses in line. I've generated > another webrev. Could you take a look and see if I've > addressed your comments? I did run a test to make sure none of the > changes caused a problem. > > webrev: > http://cr.opensolaris.org/~ginnie/4279-2/ >
Only issues are in td_mg.c. - The change Jan suggested is good, but really turns the new function into a predicate, which would argue for naming along the lines of "is_fstyp()" or something like that, along with a B_TRUE/B_FALSE return. I guess I'm not militant on this, but it would be slightly better. - The indentation and continuation usage at 1221, 1228, 1238, 1240 is incorrect. You don't need continuation markers within function argument lists, and any continuation there should be indented a half-tab, not a full one. I'm somewhat surprised that cstyle didn't complain here. Dave
