Matt Keenan wrote: > > Testing (x86): > -------------- > - Initial localized testing mimicking install completion. > Install log did not contain any warning. > > - Created ISO via Distro Constructor, containing newly build > SUNWgui-install package from slim_source workspace. > > Result : Install log did not contain any GTK Warning messages. > > > Cheers > > > > Joseph J. VLcek wrote: >> Matt Keenan wrote: >>> Joe, >>> >>> Thanks for the review. >>> >>> To recreate this message consistently I had to amended the >>> gui-install code to not call om_perform_install() and go straight to >>> the Finish Screen. >>> >>> This had the desired affect of as soon as I pressed "Install" it >>> displayed the >>> finished screen and both warnings appeared in /tmp/install_log. >>> >>> So you could say more a live cd type of test. >>> >>> I am in the process of using DC to create an a11y iso to test >>> another fix for >>> another bug and I will also be able to verify this fix in that >>> situation. >>> >>> Is this sufficient ? >>> >>> Matt >>> >>> Joseph J. VLcek wrote: >>>> Matt Keenan wrote: >>>>> CR Request for bug : >>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=2872 >>>>> assertion error at end of OpenSolaris install_log for gtklabel.c >>>>> >>>>> Webrev : >>>>> http://cr.opensolaris.org/~mattman/bug-2872/ >>>>> >>>>> >>>>> Removal of GTK assertion warnings from end of install_log file. >>>>> Two warnings >>>>> are displayed at the end of the install process, neither affect >>>>> the installation >>>>> itself, the fixes outined will remove these warnings and clean up >>>>> the log >>>>> file. >>>>> >>>>> >>>>> cheers >>>>> >>>>> Matt >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>>> Matt, >>>> >>>> The changes look fine to me but I'd be interested to know what you >>>> did to test this. I don't know this code well enough to say if >>>> these changes would result in the desired behavior. >>>> >>>> How did you test this? Which installers did you run? >>>> >>>> x86 LiveCD, AI, SPARC AI? >>>> >>>> Thanks, Joe >> That would be great Matt. >> >> After you have tested with your newly built ISO please post the >> results from your testing here on caiman-discuss. If all your tests >> pass I'm fine with you going ahead with pushing this fix. >> >> Thanks Joe > Sounds good! Thanks Matt
Joe
