Hi Matt -

The copyright date needs to be changed to 2009.
The code looks ok.
ginnie


On 08/26/09 12:18, Matt Keenan wrote:
> Any takers for reviewing this simple change ?
>
> On 08/21/09 21:11, Matt Keenan wrote:
>> CR Request for bug :
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6029
>>
>> Webrev :
>> http://cr.opensolaris.org/~mattman/bug-6029/
>>
>>
>> gui-install is run as root (via pfexec in .desktop file). When 
>> firefox is
>> launched from Welcome Screen to display Release Notes it is also run as
>> root.
>> In an accessible enabled boot e.g. screen reader grub option. A11y is 
>> only
>> enabled for the jack user. This is fine for most gtk apps as they read
>> the can rely on GTK_MODULES environment variable. Firefox has it's own
>> accessibility framework which is separate to GTK and GNOME, however 
>> it does
>> rely on the GConf key /desktop/gnome/interface/accessibility to
>> determine if
>> accessibility is turned on or not. As this key is currently not being 
>> set
>> for root, firefox when launched from gui-install is presuming 
>> accessibility
>> is not turned on, even in boots where it is.
>>
>> Solution is to amend live-a11y script and add in the setting of this key
>> for root.
>>
>> Testing:
>> - Applied changes to live-a11y
>> - Build SUNWslim-utils package using nightly onbld script
>> - Then using distro constructoer and a local IPS repo I generate
>> a LiveCD ISO containing this new SUNWslim-utils package.
>> - Launch LiveCD selecting Screen Reader grub option.
>> - Once at the desktop, launch a terminal and type "orca -l" to list
>> a11y applications that Orca see's.
>> - Now launch gui-install via Icon on desktop, and from Welcome Screen
>> click Release Notes which launches Firefox.
>> - When firefox is running, go back to terminal and re-run "orca -l", 
>> notice
>> that both gui-install and firefox are now listed.
>> Before this fix Firefox was not listed.
>>
>> - You can also verify that a11y is enabled for root via command :
>> $ pfexec gconftool-2 --get /desktop/gnome/interface/accessibility
>> This will now return "true" when booted into a11y environments.
>>
>> cheers
>>
>> Matt
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss


-- 
                                
        Ginnie 
    
    

  
                
      


Reply via email to