Hi Matt, A couple quick points:
* be_list returns BE_SUCCESS on success - you should check against that on line 796, not 0. * Is current automated test coverage sufficient to handle this change? Also, it seems like maybe there should be a libbe function that returns the "active on reboot" BE. I didn't see one when I looked though, so perhaps it doesn't exist yet, and needs to... - Keith Matt Keenan wrote: > Bug : > http://defect.opensolaris.org/bz/show_bug.cgi?id=9471 > Installer should at least try to do a fast-reboot after install > > Webrev : > http://cr.opensolaris.org/~mattman/bug-9471/ > > > Currently installer simply calls "reboot" when a user has completed > installation. The bug suggests the an attempt be made to do a fast > reboot (-f path) by default. > > To achieve this libbe can be used to get a list of BE's available > and from this list the BE which has be_active_on_reboot set on is used > as argument to reboot -f. > > If no be_active_on_reboot BE is found or be_list fails then normal > reboot will be performed. > > Testing: > - Local testing > - ISO built via Distro Constructor and installed via VirtualBox VM. > > cheers > > Matt > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
