Looks fine. Thanks Tim
Evan Layton wrote: > Tim Knitter wrote: >> Evan, >> >> Can you expand the comment on 318 to also include info describing this >> new functionality? > > Sure, I added: > > * > * Additionally while iterating through the menu, if we have an > * original root dataset for a BE we're cloning from, we need to keep > * track of that BE's menu entry. We will then use the lines from > * that entry to create the entry for the new BE. > */ > > Any better? > > Thanks! > -evan > >> Other than that it looks fine to me. >> >> Thanks >> Tim >> >>> I need to get a review the changes for >>> >>> 3654 libbe should keep menu.lst customizations when cloning >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3654 >>> >>> The webrev is available from: >>> http://cr.opensolaris.org/~evanl/webrev.3654/ >>> >>> This fix changes the way we build grub menu entries. When we're >>> creating a new BE we take a look at the grub entry lines from the >>> parent of BE we're creating and we edit the title and bootfs lines >>> the rest of the lines are copied directly form the parents entry. >>> >>> This has been tested using "beadm create" and "beadm activate" which >>> call into be_copy() and be_activate() which are the only consumers >>> of this functionality. I've also verified that changed entries in >>> menu.lst are copied from the parent BE to the entry for the >>> clone/copy. >>> >>> These changes also include some simple lint clean-up. >>> >>> Thanks, >>> -evan >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
