Hi Joe, Thank you for the code review! Since you're reviewing all the changes I've but a webrev with all the changes start to finish at: http://cr.opensolaris.org/~clayb/AI_server/webrev_complete/
Thank you, Clay On Thu, 9 Oct 2008, Joseph J VLcek wrote: > I will start looking at this today. > > Joe > > > Clay Baenziger wrote: > > Hi all, > > > > I've updated the webrev, and sent out a new code tar-ball for folks to > > work with. > > > > This update supports a "universal manifest" (based off the criteria > > schema) which embeddes the A/I manifest and all SC manifests. This > > universal manifest will be what is served out by the webserver for parsing > > by the A/I engine. An example manifest is included as [1] here. > > Unfortunately, this is a bit cludgy as it's a RelaxNG manifest which > > includes XML 1.0 DTD based XML (the SMF SC manifests). > > > > Also, due to this new universal manifest is an updated criteria schema > > allowing one to specify the A/I and SMF manifests in the criteria and > > updates to publish_manifest(1) to correctly verify everything handed in. > > > > Lastly, due to some bugs I've found the criteria collision logic got a few > > tweaks. > > > > Tar-ball: > > http://cr.opensolaris.org/~clayb/AI_server/AI_server.finalCut.1.tgz > > Webrev (just diffs off previous): > > http://cr.opensolaris.org/~clayb/AI_server/webrev1/ > > > > Thank you, > > Clay > > > > [1]: > > <ai_criteria_manifest> > > <ai_embedded_manifest> > > <ai_manifest name="default"> > > <ai_target_device> > > <target_device_name>c0t0d0</target_device_name> > > <target_device_type>SCSI</target_device_type> > > > > <target_device_vendor>hitachi</target_device_vendor> > > <target_device_size>20480</target_device_size> > > > > <target_device_use_solaris_partition>true</target_device_use_solaris_partition> > > > > <target_device_overwrite_root_zfs_pool>true</target_device_overwrite_root_zfs_pool> > > </ai_target_device> > > <ai_device_partitioning> > > <partition_action>create</partition_action> > > <partition_number>1</partition_number> > > > > <partition_start_sector>200</partition_start_sector> > > <partition_size>20480</partition_size> > > <partition_type>99</partition_type> > > </ai_device_partitioning> > > <ai_device_vtoc_slices> > > <slice_action>create</slice_action> > > <slice_number>4</slice_number> > > <slice_size>20480</slice_size> > > </ai_device_vtoc_slices> > > <ai_device_zfs_root_pool> > > > > <enable_mirrored_root>true</enable_mirrored_root> > > <zfs_options>xyz</zfs_options> > > </ai_device_zfs_root_pool> > > <ai_device_swap> > > <ai_swap_size>2048</ai_swap_size> > > </ai_device_swap> > > <ai_pkg_repo_default_authority> > > <main url="http://pkg.opensolaris.org" > > authname="opensolaris.org"/> > > <mirror url="" authname=""/> > > </ai_pkg_repo_default_authority> > > <ai_packages> > > </ai_packages> > > </ai_manifest> > > </ai_embedded_manifest> > > <sc_embedded_manifest name = "AI"> > > <!-- <?xml version='1.0'?> > > <!DOCTYPE service_bundle SYSTEM > > "/usr/share/lib/xml/dtd/service_bundle.dtd.1"> > > <service_bundle type="profile" name="name"> > > <service name="ai_properties" version="1" type="service"> > > <instance name="default" enabled="true"> > > <property_group name="ai" type="application"> > > <propval name="username" type="astring" > > value="jack"/> > > <propval name="password" type="astring" > > value="jack"/> > > </property_group> > > </instance> > > </service> > > </service_bundle> > > --> > > </sc_embedded_manifest> > > </ai_criteria_manifest> > > _______________________________________________ > > caiman-discuss mailing list > > caiman-discuss at opensolaris.org > > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > >