Clay Baenziger wrote: > Hello Sundar, > You and I have exchanged a few e-mails about the architecture of > installadm. I have written up what I think is the correct type of code for > integrating the Python scripts into installadm (of course, pending our > discussion about options). Could you look the code over and tell me if I'm > making any newbie Solaris engineer mistakes, or if the code is going > against any architectural intentions you had for installadm? > > The webrev is at: http://cr.opensolaris.org/~clayb/installadm/webrev.0/ > > Thank you, > Clay > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > Clay,
Run through cstyle (hg pbchk will do that for you). There are some alignment issues. 680, 960, 992: You should capture the return value and provide a meaningful error messages for different values if needed. 652, 662: You cannot use MSG_LIST_SERVICE_FAIL here because the message will be "Failed to list Install Services" and your code is trying to list manifests. You have to add new messages in the installadm.h file and use it. 606: Need block comments to do_list(), do_add and do_remove(). The comments do not include your changes to add new options to list and remove subcommands. - Sundar
