OK, I'll try this again then...
AI_database.py:
--------------------
set/getResponse:
113: Return isn't needed after a raise
DB routines: OK
webserver.py:
----------------
get/setService:
Same question as before about just testing self._service on 523 as if
(self._service != None)
get/setManifestPath:
Same question as before about just testing self._manifest on 614 as if
(self._manifest != None)
Thanks,
Jack
Clay Baenziger wrote:
> Hi Sue,
> Yes, I put the wrong webrev up and forgot cr.opensolaris.org and
> scp doesn't clobber. The right one's there now. My apologies for the time
> waste.
> Thank you,
> Clay
>
> On Thu, 16 Oct 2008, Susan Sohn wrote:
>
>
>> Hi Clay,
>>
>> I brought up rc4 and I'm not seeing the changes. The permissions are still
>> 744, etc.
>>
>> Sue
>>
>> Clay Baenziger wrote:
>>
>>> Hi Sue,
>>> Thank you for checking out my prototype_com. I had the permissions
>>> set that way since only root can do anything with the commands, however,
>>> as each program has a root uid check and error message now, I've corrected
>>> the permissions to 755. I hadn't realized there wasn't an entry for var.
>>> There is now.
>>>
>>> I'm now at http://cr.opensolaris.org/~clayb/AI_server/webrev_final_rc4
>>>
>>> Thank you,
>>> Clay
>>>
>>> On Thu, 16 Oct 2008, Susan Sohn wrote:
>>>
>>>
>>>> Clay Baenziger wrote:
>>>>
>>>>> Hi Dave and Jack,
>>>>> You both raised concerns with the response(), manifestPath(),
>>>>> service() and database() functions in AI_database, and publish_manifest
>>>>> which did not have explicit set and accessor functions. I've have
>>>>> corrected that in:
>>>>> http://cr.opensolaris.org/~clayb/AI_server/webrev_final_rc3/.
>>>>>
>>>>> Thank you,
>>>>> Clay
>>>>>
>>>> Clay,
>>>>
>>>> Couple of questions on SUNWinstalladm-tools/prototype-com:
>>>> 47 - Why are you removing the entry for var?
>>>> 48 - Why don't publish-manifest and delete-manifest have 755 permissions
>>>> the way
>>>> list-manifests does?
>>>>
>>>> Sue
>>>>
>>>>
>>
