Tim, These are just nits --
945-947 - Can you turn these negatives into positives? e.g. " ... that beadm is executing in the global zone." 950 - Would the zonename command ever not exist on the system? If it didn't exist, or if it failed for whatever reason, I think we should err on the global side and assume we're in the global rather then a non-global shouldn't we? 961 - Instead of this assumption, could you check the last char of zonename is indeed '\n', and remove it before comparing it to "global" ? thanks, -ethan Tim Knitter wrote: > Can two people please review the following: > > 3775 beadm should check that it is being run in a non-global zone > > http://defect.opensolaris.org/bz/show_bug.cgi?id=3775 > http://cr.opensolaris.org/~tsk/3775/ > > I tested these changes on bld 99 in both a non-global zone and a global zone. > > Thanks > Tim > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
