Alok Aggarwal wrote:
> Hi Jan,
>
> On Thu, 16 Oct 2008, jan damborsky wrote:
>
>> could I please ask you to review the fix for following AI bug ?
>>
>> 3977 /lib/svc/method/auto-installer exits with $SMF_EXIT_OK even if 
>> AI engine fails
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3977
>>
>> webrev:
>> http://cr.opensolaris.org/~dambi/bug-3977/
>
> Looks fine, the fix on line 141 makes me think
> you did actually fully test the fix :)

Yeah, line 141 was completely broken ;-)

Thank for the review,
Jan


Reply via email to