Evan Layton wrote:
> Hi Ethan,
>
> The changes look really good to me. Just a couple of minor nits.
>
> Nits:
> We're testing against 0 here
> 1016 be_get_uuid(bt.obe_root_ds, &uu) == 0) {
> But against BE_SUCCESS here
> 1042 &fld, newmp)) != BE_SUCCESS) {
>
> Since we're in this code we should make these match.
>
Alright, I'll fix that.
> This was already here but could use some tlc...
> 1028 update -> updated
>
I'm not seeing what you're suggesting needs to be changed here.
-ethan
> Thanks!
> -evan
>
> Ethan Quach wrote:
>
>> This fix address both 3844 and 3901. Upon creation of a boot
>> environment, we now make sure that its mountable before deeming
>> it a success. We also now catch zone creation errors instead of
>> silently ignoring them. Upon creation failure, we now cleanup
>> the incomplete boot environment instead of leaving its bits and
>> pieces around.
>>
>> I've tested this with cases where the source BE has faulty
>> subordinate datasets, and also where just some random error
>> happened while processing a subordinate dataset. I've also tested
>> these above scenarios with and without zones, and where copying
>> a zone caused an error.
>>
>>
>> Webrev:
>> ----------
>> http://cr.opensolaris.org/~equach/webrev.3844.3901
>>
>> Defects:
>> ----------
>> 3844 be_copy_zones() silently ignores
>> zoneshttp://defect.opensolaris.org/bz/show_bug.cgi?id=3844
>>
>> 3901 libbe: a failed beadm create can fail to clean up a partially
>> created BE and leaves it mounted
>> http://defect.opensolaris.org/bz/show_bug.cgi?id=3901
>>
>>
>> thanks,
>> -ethan
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
