Thanks and I am okay with the changes:)
-M
Susan Sohn wrote:
> Moriah,
>
> Thanks for the review. Comments below.
>
> Moriah Waterland wrote:
>> Sue,
>>
>>
>> I have a question about your changes with using dirname in the following
>> files.
>> * usr/src/cmd/installadm/create-client.sh
>> * usr/src/cmd/installadm/installadm.c
>>
>> Was there a technical reason behind why the following code was used in
>> installadm.c to assign dirname instead of just a straight-forward
>> setting of the directory name?
>>
>> 144 /*
>> 145 * Get directory info for calling subcommands
>> 146 */
>> 147 (void) strlcpy(fullpath, progname, sizeof (fullpath));
>> 148 ptr = (char *)strrchr(fullpath, '/');
>> 149 if (ptr == NULL) {
>> 150 /*
>> 151 * Command called from current directory
>> 152 */
>> 153 dirname = "";
>> 154 } else {
>> 155 /*
>> 156 * Path is either absolute or relative with a '/'
>> in it.
>> 157 */
>> 158 *ptr = '\0';
>> 159 strcat(fullpath, "/");
>> 160 dirname = strdup(fullpath);
>> 161 }
>>
>
> I was trying to do it in such a way so that that paths weren't hardcoded and
> that if all the scripts/files moved to another directory, it would still work
> without having to change the code.
>
>> Also, I have a minor nit:
>> usr/src/pkgdefs/SUNWinstalladm-tools/prototype_com.frames.html
>> 48 d none usr/lib 0755 root bin
>> convention for the files is just "755"
>
> I copied that line from one of the other packages. Several have it that way
> (for
> example: SUNWinstall-libs, SUNWinstall, SUNWbeadm).
>
> Sue
>
>> Otherwise, it looks fine.
>>
>> -Moriah
>>
>> Sundar Yamunachari wrote:
>>> Sue,
>>>
>>> It looks good now.
>>>
>>> - Sundar
>>>
>>> Susan Sohn wrote:
>>>> Sundar and Moriah,
>>>>
>>>>
>>>>> Sundar Yamunachari wrote:
>>>>>
>>>>>> Susan Sohn wrote:
>>>>>>
>>>>>>> Please review the changes for:
>>>>>>>
>>>>>>> 4040 installadm packaging needs changes
>>>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=4040
>>>>>>>
>>>>>>> which are posted at:
>>>>>>>
>>>>>>> http://cr.opensolaris.org/~sohn/4040
>>>>>>>
>>>>>>>
>>>>>>> Thanks,
>>>>>>> Sue
>>>>>>> _______________________________________________
>>>>>>> caiman-discuss mailing list
>>>>>>> caiman-discuss at opensolaris.org
>>>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>>>>
>>>>>>>
>>>>>> *usr/src/pkgdefs/SUNWinstalladm-tools/prototype_com:
>>>>>>
>>>>>> *57: publish-manifest and delete-manifest are missing in the modified
>>>>>> file.
>>>>>>
>>>>>> - Sundar
>>>>>>
>>>>> Thanks, I'll add them back in.
>>>>> Sue
>>>>>
>>>> I've updated the webrev, same location.
>>>>
>>>> Sue
>>>> _______________________________________________
>>>> caiman-discuss mailing list
>>>> caiman-discuss at opensolaris.org
>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
