Hi Karen.
On 10/23/08 23:24, Karen Tung wrote:
> Hi Jack,
>
> Here are my comments:
>
> bootroot_initialize.py:
> - Instead of all the changes you made in 96-113, I think it would be
> much simpler to
> just completely remove the whole bootroot build area, and then,
> recreate it using
> os.mkdir(BR_BUILD). The python function shutil.rmtree() can be used
> to remove
> the whole directory without doing a os.system(). I tried it, it works
> for dot files as well.
Yup. Thanks. Much better solution. Here's what I've got now:
# Clean out any old files which may exist.
try:
shutil.rmtree(BR_BUILD)
except OSError:
print >>sys.stderr, (
"Error purging old contents from bootroot build area")
raise
try:
os.mkdir(BR_BUILD)
except OSError:
print >>sys.stderr, "Error creating bootroot build area"
raise
>
> usbcopy:
> -line 29: that's not a good way to check to make sure that the user is
> root. /usr/bin/id
> will show information about user and group. So, a user who is not root
> might belong to the group of "root". I think a better way to do it is
> /usr/bin/id -u
> This shows you the uid only, and you just compare that to make sure it
> is "0".
Thanks. Changed to:
if [ `/usr/bin/id -u` != "0" ] ; then
echo "Must be root to run."
exit 1
fi
>
> The documentation changes seemed to be missing the update to the man
> page. I believe
> Barbara included a man page to update the one that's in the gate.
Yup. Got it.
Thanks for your inputs. Webrev updated.
Thanks,
Jack
>
> Thanks,
>
> --Karen
>
> Jack Schwartz wrote:
>> Hi everyone.
>>
>> Webrev updated to now include documentation update (from Barbara) and
>> Jean's comments, including one other small nit reported from Jean
>> when she code reviewed during the last round, which required its own
>> bug ID:
>>
>> 4200 ai_manifest.defval.xml repo default authority default needs
>> updating
>> 4201 Distro-constructor documentation update 10/23/2008
>>
>> Same location:
>> http://cr.opensolaris.org/~schwartz/081022.1/webrev/index.html
>>
>> Thanks,
>> Jack
>>
>> On 10/22/08 20:46, Jack Schwartz wrote:
>>
>>> Hi everyone.
>>>
>>> Please review (small-ish) changes for the following DC bugs:
>>>
>>> 3355 usbcopy utters that device is not writable when root privs needed
>>> 3913 Distro Constructor keeps resetting my coreadm settings
>>> 3944 DC should give a traceback when it bombs
>>> 3957 AI defval manifest has to start with "DC-manifest_defval"
>>> 3959 ManifestServ and ManifestRead usage statement tweeks
>>> 3960 ManifestRead modules can use some restructuring
>>> 4009 Remove nm_list_type from defval manifest schema
>>> 4133 Need to clear out dot files when reinitializing bootroot
>>>
>>> Webrev:
>>> http://cr.opensolaris.org/~schwartz/081022.1/webrev/index.html
>>>
>>> Please send your comments/questions by Friday 10/24 lunchtime.
>>>
>>> Thanks,
>>> Jack
>>>
>>>
>>>
>>>
>>>
>>
>> _______________________________________________
>> caiman-discuss mailing list
>> caiman-discuss at opensolaris.org
>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>>
>
