Hi Karen, bootroot_initialize.py:
Nit for future: 194 status = os.system(find_no_excl_cmd % (item)) Using the subprocess module is the preferred way of spawning new processes with Python. pre_bootroot_pkg_image_mod: 79 # This file is big, and it is not really needed. pkg(5) will re-created 80 # if it is needed. -> 79 # This file is big, and it is not really needed. pkg(5) will re-create 80 # it if it is needed. 82 ${RM} -rf $PKG_IMG_PATH/var/pkg/catalog/catalog.pkl The -r isn't needed since this is a file and not a directory. Thanks Tim > Hi, > > Can I get 2 reviewers for the changes for bug 4293. > > 4293: x86.microroot seems larger than it needs to be > http://defect.opensolaris.org/bz/show_bug.cgi?id=4293 > > webrev: > http://cr.opensolaris.org/~ktung/4293_fix > > Thanks > > --Karen > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss