Glenn Lagasse wrote: > * Dave Miner (Dave.Miner at Sun.COM) wrote: >> Glenn Lagasse wrote: >>> Sanjay and Dave (and anyone else who would like), >>> >>> Could you please re-review my changes for: >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=817 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=818 >>> >>> I've moved the files from the slim_prototype gate to the slim_source >>> gate as well as addressed any issues uncovered in the first review. >>> >>> http://cr.opensolaris.org/~glagasse/817_818_new/ >>> >> Sorry to do this to you, but my changes for 497 did an extensive >> rearrangement of the Makefile structure in cmd/slim-install, you need to >> sync up with that and I'll re-review. The non-Makefile parts here seem OK, >> though. > > No worries. Here's the updated webrev: > > http://cr.opensolaris.org/~glagasse/817_818_update/ >
Changes are OK. Just make sure you do an "hg recommit" to get rid of the merge changeset and comment. Dave
