jan damborsky wrote: > Roland Mainz wrote: > > jan damborsky wrote: > >> William James wrote: > >>> On Tue, Apr 8, 2008 at 4:30 AM, Dave Miner <Dave.Miner at sun.com> wrote: > >>>> Jan Damborsky wrote: [snip] > >> I chose the bash due to the time constraints - > >> at that point I was more familiar with bash than > >> ksh93. > > > > To end this debate - attached is a ksh93 version of the script. I did > > some minor changes in functionality, e.g. ... [snip] > > The script is attached as "set_lang.ksh" ... > > thank you very much for your time and coming > with the proposal.
No problem... > Since the original fix already went through > the code review process and was already integrated, > I think you would need to file new bug, ... see http://defect.opensolaris.org/bz/show_bug.cgi?id=1060 ('Alternative script for language selction ("set_lang.ksh")') > if you > would like to integrate your changes into the gate. Technically I only wrote the patch to end the bickering (since I sometimes wish people would write more code and do less bickering) and to show how the script could make use of ksh93 features (your script would AFAIK work with both bash and ksh93, I only did some cleanup and some changes to use more ksh93 features (e.g. compound variable arrays which are AFAIK quite usefull in this case where you have label/value pairs (e.g. I merged the two arrays in your script into one array where each array element contains two values)) ... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 7950090 (;O/ \/ \O;)
