Looks ok to me.

-Sanjay



Jan Damborsky wrote:
> Hi,
>
> could I please ask for reviewing fix for following issues ?
>
> 1633 backout ZFS part of fix for 770 due to the failing "zpool import"
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1633
>
> 1567 orchestrator should unmount ZFS dataset before resetting the mountpoint 
> property
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1567
>
> Fix for 1633 removes problematic "zpool import" command from orchestrator
> code - this one which is triggering 1350.
>
> The fix doesn't address
>
> 1610 installer should not lie
>
> This one would require substantial changes in install-finish & mkmenu
> commands as far as error detection and handling is concerned, since that
> was being a little bit neglected (to be modest) during design & implementation
> phases.
>
> * Webrev:
> http://cr.opensolaris.org/~dambi/bug-1567-1/
>
> * Testing done:
> [1] Booted LiveCD RC2
> [2] liborchestrator replaced
> [3] Installation into existing Solaris instance in vmware was done
>
> Results:
> * New Solaris instance booted successfully
>
> Thank you very much,
> Jan
>
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
>   


Reply via email to