Ethan Quach wrote: > Evan, > > 1005 - Rather than pulling this case out, can we instead pass > in an option to be_open_menu() to either create a fresh menu > or just exit?
Sure! Fixed... > > 3268 - I know its not part of this fix, but shouldn't this > fopen call take 'mode' instead of "r"? Yes it should be. Nice catch!!! Changes made and webrev updated. Thanks for looking at this!!! -evan > > > thanks, > -ethan > > > > Evan Layton wrote: >> Hi Ethan, >> >> When you get a chance can you take a look at this for me? >> >> Thanks! >> -evan >> >> Evan Layton wrote: >>> Hi, >>> >>> I need to get a review the following simple fix. >>> >>> Some background: This bug was caused by the fix for 5221 which >>> introduced >>> the functionality to add a menu.lst file if it was found to be missing. >>> While this is normally a good thing it was also being used by be_list >>> when checking for the default BE in the grub menu, which really doesn't >>> make sense anyway because there isn't a file so no grub default. For >>> be_list when it can't get the default BE from the grub menu it defaults >>> to getting this information from the zpool bootfs property. The problem >>> with be_list creating the menu.lst file is that libtd uses be_list to >>> check for existing BE's but does this before the ICT's run and create >>> the >>> menu.lst file. It was this that caused the problem... >>> >>> 6738 b108 generates the wrong grub menu for text boot and it fails to >>> boot for x86 >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6738 >>> >>> Webrev: >>> http://cr.opensolaris.org/~evanl/6738 >>> >>> Thanks! >>> -evan >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>
