Hi, could I please ask for reviewing changes for following bug ?
6556 AI should provide an option for automatic reboot after an install http://defect.opensolaris.org/bz/show_bug.cgi?id=6556 webrev: http://cr.opensolaris.org/~dambi/bug-6556/ Thank you very much, Jan This fix implements support for automatic reboot feature. Comparing to the short proposal sent for this fix, following modifications were introduced during the implementation: original proposal: ------------------ ... [2] If 'ai_auto_reboot' option is provided and set to 'true', AI would 'touch' file in /tmp/ directory as indicator that auto reboot should take place. ... implementation: --------------- Instead of using file for indicating that automatic reboot is required, Automated Installer exit with user exit code appropriately recognized and processed by caller (auto-installer SMF service) While I was in that code, I also did additional changes: * fixed "6951 Ensure messages printed to console when starting Auto Install" * If installation failed, AI engine exited with -1 exit code which was converted to >128 value. Since >128 values are reserved for cases when process is terminated with signal, failure return code was changed to 1. Testing ------- HW: * AI server - Laptop Lenovo X61 * AI client - - x86: Ultra 20 (1GB RWM) - Sparc: T1000(8GB RWM) SW: * AI image created based on build 108 * installation done from http://ipkg.sfbay/dev Test cases ---------- AI server - new SUNWinstalladm-tools package installed - manifest containing <ai_auto_reboot> tag successfully added using 'installadm add' AI clients * successful installation with manifest - containing ai_auto_reboot set to true (auto reboot took place) - containing ai_auto_reboot set to false (auto reboot didn't happen) - without ai_auto_reboot tag (auto reboot didn't happen) * for Sparc, boot-device was set to 'net:dhcp' before AI - it was correctly set by ICT to point to the target disk. * check done that in case of failure this one is correctly reported on console and auto-installer goes into maintenance mode -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090303/04949033/attachment.html>
