Clay,
pkginfo.tmpl NAME= looks like a package name and it should be a short 
name for humans to read.

I thought that new package names were not going to be prefaced with 
SUNW.  Please check current policy on new package names.

Seeing publish_manifest.py in the review with Makefiles makes me wonder 
if we should start using symbolic references to common pathnames in 
Python.  Consider making a Python constant with the same name as in 
Makefile.master: 
  ROOTAUTOINST=           $(ROOT)/usr/share/auto_install

All new files: update copyright year.  Doesn't hg nits report this?

Please document the new package dependency chain in bugzilla - just a 
few lines to help visualize.

William

Clay Baenziger wrote:
> Hi William,
>     Can you look at this webrev for 6166? I think it achieves what you 
> were hoping to do with a new SUNWauto-install-common. I've updated the 
> files which seemed affected and tested the server. I'm deferring 6280 
> until after this release, as it'll be a lot of change I think.
>
> Webrev:
> http://cr.opensolaris.org/~clayb/6166/webrev/
> Bug:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=6166
>
>                             Thank you,
>                             Clay

Reply via email to