Hi Sue,
On 03/09/09 00:10, Sue Sohn wrote: > Jan Damborsky wrote: >> Hi Sue, Sundar, >> >> >> Sundar Yamunachari wrote: >>> Susan Sohn wrote: >>>> Please review the changes for: >>>> >>>> 6128 installadm reuses /var/ai data and screw up manifest >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=6128 >>>> >>>> and >>>> >>>> 7122 installadm stop kills /usr/bin/dns-sd for all services of >>>> similar name >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7122 >>>> >>>> which are posted at: >>>> >>>> http://cr.opensolaris.org/~sohn/6128_7122 >>>> >>>> Thanks, >>>> Sue >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> installadm.c: >>> >>> 468: Can you add a comment on why normalize_service() is needed for >>> service_name? >> >> It seems that once 5091 is fixed (currently in process of code >> review), all code related >> to 'normalized service' will turn into no-op, since characters >> processed there will not >> pass check fix for 5091 is going to introduce: >> >> http://cr.opensolaris.org/~schwartz/090306.1/webrev/usr/src/cmd/installadm/installadm.c.cdiff.html >> >> >> >> Based on this, I think that all that code can be removed. > > Jan, > > Thank you for pointing that out. However, I would much prefer that > this be done as a separate bug fix after I push what is currently > being reviewed. That is fine - would you like me to file bug for this ? Thank you, Jan > > Thanks, > Sue > > >> >> Thank you, >> Jan >> >
