Hi Sundar,
On 03/09/09 08:41, Sundar Yamunachari wrote: > Jan, > > I will review your code again after your Sue's code push. Thanks ! > > jan damborsky wrote: >> >> This mechanism is used for passing parameters to functions >> defined in installadm-common.sh - create_menu_lst_file >> in our particular case. I am not sure why this approach was >> originally taken, but seems like a good candidate for refactoring - >> it is confusing and error prone. >> Should I file bug for this or might there be desire for redesigning >> installadm tools and reimplement them in Python language - having thought >> about the challenges we will encounter in future with respect to >> discussed >> requirements (working in heterogeneous environment, need for abstracted >> API, being able to plug-in into different kind of implementations >> of consumed technologies), I would vote for this :-) > Please file a bug with this information. When we take up refactoring, > we will make sure that this gets fixed. I have filed following bug: 7207 setup-tftp-links.sh uses global variables for passing parameters to functions I have put 'installadm_refactor' keyword in Whiteboard to indicate that this is 'refactor' kind of bug - those would be addressed as a whole if/when installadm tools are to be redesigned/reimplemented in Python. I am not sure if this is the right mechanism - please let me know if another one might be more suitable (like introducing common blocker bug). Thank you, Jan -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090309/b2eec37c/attachment.html>
