On 03/09/09 12:37, Jean McCormack wrote: > > Can I please get a code review for 4488 > > CR: > http://defect.opensolaris.org/bz/show_bug.cgi?id=4488 > > Webrev: > http://cr.opensolaris.org/~jeanm/slim_4488/ > > Jean > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Hi Jean, Just one comment (that I haven't already seen): In installadm.c:do_disable, you need to add a check to make sure the user has entered a service name. Thanks, Sue
