Hi Joe, As Jack has also pointed out in his review comments, I don't think the additional entries for enabling ssh should go into grub_setup.py. grub_setup.py should only contain "base" entries for the grub menu, because that might get called when other kind of images (non Live CD) is created. Enabling ssh is only applicable for the Live CD.
The "sed" command in ict.py seemed to be very complicated. Python is powerful in manipulating files and strings, perhaps you can file a RFE to look into converting that logic into pure python in the future. Thanks, --Karen Joseph J VLcek wrote: > Hello Caiman-ites, > > OK, let's try this again shall we. This time with the pointer to the > webrev! ;) > > (Thanks for pointing out it was missing Karen! ;) > > Could I please get a code review for the changes for bugs 6431 and 7077. > > Huge thanks! Joe > > Webrev: > http://cr.opensolaris.org/~joev/bug6431_7077/ > > 6431 ssh or rlogin service should be enable in install image for > automated testing > > http://defect.opensolaris.org/bz/show_bug.cgi?id=6431 > > > 7077 ICT - remove GRUB entry "text boot > > http://defect.opensolaris.org/bz/show_bug.cgi?id=7077 > > Note regarding 6431: > -------------------- > This fix is for the GUI installer. The required changes for the AI > installer will be tracked in bug 4443. See the bug for more info. > > Description of change for 7077: > ------------------------------- > > The additional "text boot" GRUB menu entry went in to the gate at: > > changeset: 350:cbcc5f485007 > user: Joseph J Vlcek <Joseph.Vlcek at Sun.COM> > date: Thu Nov 13 22:13:04 2008 -0700 > summary: 4673 Grub text only mode is required > > I reverted the section of the affected code to the way it looked in > the previous rev. > > modules affected: > ----------------- > > * Distro Construction (grub_setup.py) > * LiveCD Image > > testing done: > ------------- > > Using DC, I built an image with the updated grub_setup.py > > I then used lofiadm to add the updated live-fs-root and set_lang to > the image. > > Booted the live image and confirmed: > - A new "ssh enabled" GRUB entry is available. > - ssh is enabled on the live desktop > - the default language settings are made. > > To test the changes to ict.py for bug 7077: > > On the live desktop I used mount -F lofs... to introduce the updated > ict.py file, performed a full GUI install and confirmed the "text > boot" entry was no longer presented by GRUB. > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
