Thanks Jedy!  I had difficulty applying the last patch you attached, but 
did some hand editing of the file.  The complete diff I have from hg 
trunk is attached.

With this patch in place, what I now see happening is that when the 
Welcome screen appears, focus is now transferred to the invisible disk 
radio button on the next page.  Very strange, but the net result is that 
Orca now speaks the disk information when the user is still on the 
"Welcome" screen.

I looked at the rest of the gui-install code and I'm having trouble 
figuring out why this is happening.  From what I can tell, the code path 
for setting focus should only be called when the disk screen appears. 
But, I only gave it a 5 minute look.  :-(  Do you have any ideas?

Will

Jedy Wang wrote:
> Hi Will,
> 
> I just updated my patch and the webrev. Now the fix should not have such
> problem. A diff between the old patch and the now one is also attached.
> 
> Regards,
> 
> Jedy
> On Tue, 2009-03-24 at 12:03 +0000, Willie Walker wrote:
>> Hi Jedy:
>>
>> This definitely makes the radio button behavior work much better and is 
>> consistent with how GTK+ radio button groups work.  Many thanks!
>>
>> One thing I noticed, however, is that when going from the initial 
>> "Welcome" screen to the disk selection screen, the focus now remains on 
>> the "Next" button rather than going to a disk. :-(
>>
>> Many thanks again for your work here,
>>
>> Will
>>
>> Jedy Wang wrote:
>>> Hi all,
>>>
>>> Please review the patch which fixes  bug 7436 - disk radio button
>>> behaves like toggle button and breaks Orca.
>>>
>>> The fix makes disk buttons behave like radio button by toggling them
>>> when they get focus. The patch also fix the default widget problem for
>>> disk screen. For details, please refer to
>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7436
>>>
>>> webrev:
>>> http://cr.opensolaris.org/~jedy/7436/
>>>
>>> Regards,
>>>
>>> Jedy
>>>
>>>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: installation-disk-screen.diff
URL: 
<http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090325/71949b00/attachment.ksh>

Reply via email to