William,
Thanks for the review. I will forward your comments to Barbara.
Thanks,
Sundar
William Schumann wrote:
> Sundar,
> Nit: appendix.html should include a reference to Automated Installer
> Files (aifiles.html) under "For reference, see the following..."
> (although it does appear on the left).
> Nit: aimanifest.html XML source seems to be stripped of indentations.
> These are not your changes, but indentations between <pre> and </pre>
> should reflect the indentations in the original XML ideally.
> William
>
>
> Sundar Yamunachari wrote:
>> Sue, Jan, William:
>>
>> Please do a code review for the blocker bug 7339. This is to
>> integrate 2009.06 AI documents in the source gate. The AI will be
>> installed on the install server when SUNWinstalladm-tools gets
>> installed. The only changes I made are in Makefile and prototype_com.
>> The html files were provided by Barbara. The old html files
>> (gettextid-<num>.html) are removed and replaced by set of new html
>> files.
>>
>> The webrev is at http://cr.opensolaris.org/~ysundar/7339/
>>
>> The bug is at http://defect.opensolaris.org/bz/show_bug.cgi?id=7339
>>
>> Thanks,
>> Sundar
>>
>>
>> Testing:
>>
>> 1. Added the new documentation and built SUNWinstalladm-tools
>> 2. Installed it on a test machine running OpenSolaris 101a
>> 3. Access the documentation. Clicked on all links and make sure that
>> there are no broken links. Verified whether the documentation is the
>> same as the one we are reviewing right now.
>> 4. Test the integration of new package.
>>
>> # /net/paradise.sfbay/export/tools/bin/integrate -l install -r
>> nv_osol0906 -n SUNWinstalladm-tools
>> ##############################################################################
>>
>>
>>
>> (TEST MODE ONLY) Integrating Package 'SUNWinstalladm-tools' to
>> nv_osol0906 ...
>>
>> Sending item information to server for verification ...
>>
>> WARNING:Depend_PKG_MustExistInRelease:nv/SUNWinstalladm-tools(i386):
>> nv/missing_depend_pkg=SUNWpython-cherrypy # PKG must exist in release
>>
>>
>>
>> STATUS = PASSED (Test mode only, no item is integrated)
>>
>> ##############################################################################
>>
>>
>>
>> See http://spgweb.sfbay/SPE/SRE/Tools/re_audits.html for audit help.
>>
