Sundar Yamunachari wrote: > Ethan,* > > usr/src/lib/libict/ict.c: > > *486-489 - The checking of target could be moved before line 481 -- the > target could be null
I'll move this up. > > 547-559 - Does it make sense to update the file after completing both > the tasks (changing root and user)? If first one is successful and > second one is not successful, we may have partially updated file. If anything fails here, ICT is going to report a failure which causes an overall install failure anyway, but I see your point. I'll move lines 561-564 up above 547 (making sure it modifies the tmp_ua file). > > *usr/src/lib/libict/ict_test.c: > > *55, 77, 118, 123-124: Are these changes part of this bug fix? Its cleanup from 5554. Somebody forgot to update those when the set_host_node_name() interface was modified so I'm fixing it here. Without these changes, 'make ict_test' fails to build. (I think Joe's got these in his webrev as well, but we'll just have to merge.) thanks, -ethan > > Thanks, > Sundar > > Ethan Quach wrote: >> Can I get a review for this blocker... >> >> >> Webrev: >> ------ >> http://cr.opensolaris.org/~equach/webrev.4215/ >> >> >> Defect: >> ------ >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4215 >> >> >> >> Tested this fix by installing via the LiveCD and AI, >> with and without a login name specified. All tests >> succeeded as expected. >> >> >> >> thanks, >> -ethan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
