Jack Schwartz wrote: > Hi everyone. > > Please review a simple fix to remove trailing slashes from installadm > create-service target directories. > > Bug: http://defect.opensolaris.org/bz/show_bug.cgi?id=3773 > > webrev: http://cr.opensolaris.org/~schwartz/090326.1/webrev/ > > Tested by providing installadm create-service commands with target dirs > containing 0-2 trailing slashes. > > Thanks, > Jack > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
Looks good Jack. As we discussed on the phone. Please add a function description including the 2 boundary cases we discussed. That being: Blank spaces at the end of the line are "not" ignored. So it a blank space follows any trailing slashes the slashes will not be removed. If a one character string containing a slash is passed in the result with be an empty string. And as you pointed out it would make more sense to put this in installadm_utils.c: usr/src/cmd/installadm/installadm_util.c Joe
