HI Sue. Thanks for adding the pntadm message.
thanks, Jack P.S. I only quickly scanned the rest of the code so please don't count me as a full code reviewer. That said, the code looks alright to me. On 04/01/09 11:19, Sue Sohn wrote: > Hi Sarah, Sundar, and Jack, > > Thank you for the review and feedback. > > I have added the new output to the script and have updated the webrev. > > Thanks, > Sue > > Jack Schwartz wrote: >> HI everyone. >> >> On 04/01/09 05:54, Sarah Jelinek wrote: >>> Sundar Yamunachari wrote: >>>> Sarah Jelinek wrote: >>>>> Hi Sue, >>>>> >>>>> In the case of needing to add a static ip for the client on the >>>>> dhcp server, we need to run pntadm, correct? Assuming the user has >>>>> not setup a set of addresses for clients in their dhcp server. >>>>> >>>>> Do we need to address this case in this bug? I ran in to this >>>>> issue yesterday, specifically I ran the dhtadm commands but my >>>>> client couldn't boot because the I didn't have the clients ip >>>>> address setup. I didn't know this, and when I ran the dhtadm >>>>> commands it didn't fail, so I was kind of clueless. Sundar helped >>>>> me understand the issue. >>>>> >>>>> I am not sure it is feasible to provide this type of information, >>>>> unless we check somehow. Is there a way to check? The dhtadm >>>>> command will return 0 even in the case I describe above. >>>> Sarah, >>>> >>>> pntadm uses to add, delete or modify IP address records in the >>>> DHCP table. Since DHCP server is remote, we can not check what IP >>>> addresses are available in the DHCP server or which address should >>>> be assigned to the client. However, we could tell the user that IP >>>> address assignment for the client or set of clients should be done. >>>> >>> That seems like a reasonable compromise. That is letting the user >>> know that the IP address assignment for the client should be done. >> I think this is a great idea! This nicely handles what I was talking >> about in yesterday's meeting. >> >> I suggest putting some kind of quick reference in the message, for >> example: >> >> "Note: be sure to assign client IP address if needed (e.g. run >> pntadm(1M))" >> >> Thanks, >> Jack >>> >>> >>> Thanks for the explanation. >>> >>> sarah >>>> - Sundar >>>>> >>>>> thanks, >>>>> sarah >>>>> *** >>>>>> Please review the changes for: >>>>>> >>>>>> 7747 Installadm should print actual commands needed for the DHCP >>>>>> setup >>>>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7747 >>>>>> >>>>>> which are posted at: >>>>>> >>>>>> http://cr.opensolaris.org/~sohn/7747 >>>>>> >>>>>> Thanks, >>>>>> Sue >>>>>> _______________________________________________ >>>>>> caiman-discuss mailing list >>>>>> caiman-discuss at opensolaris.org >>>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>>> >>>>> _______________________________________________ >>>>> caiman-discuss mailing list >>>>> caiman-discuss at opensolaris.org >>>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>>> >>> >>> _______________________________________________ >>> caiman-discuss mailing list >>> caiman-discuss at opensolaris.org >>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >