Jan, * usr/src/cmd/auto-install/auto_install.c* Can you change enable_debug_mode() to set_debug_mode() and is_debug_mode_enabled() to get_debug_mode()? This will make it more clear and if want to allow setting more than one debug value in the future, it will be simpler.
1582: Add a break after this line. What about having a default case to display usage and exit if the user specifies any other option? 1615-1626: Needed only if debug_is_enabled. Can you move it with in the block 1597-1613? - Sundar jan damborsky wrote: > Hi, > > could I please ask for reviewing changes for following bug ? > > 4443 Automated Installer needs support for better observability > http://defect.opensolaris.org/bz/show_bug.cgi?id=4443 > > webrev: > http://cr.opensolaris.org/~dambi/bug-4443 > > Thank you very much, > Jan > > > summary of changes: > ------------------- > > * remote access via ssh is enabled if 'livessh' option is set to > 'enable' in install configuration file (menu.lst or install.conf) > > * installer is run in debug verbose mode if 'install_debug' option > is set to 'enable' in install configuration file (menu.lst or > install.conf): > > - debug verbose level is set to the highest one (LS_DBGLVL_INFO) for > liblogsvc > logging service (affects TD, TI, orchestrator, transfer module, AI) > > - BE_PRINT_ERR=true > > - following pkg(1) subcommands are run in verbose mode ('-v' option > is appended) > > - pkg install > - pkg uninstall > - pkg list > > > modules affected: > ----------------- > * transfer module > * live-fs-root > * AI (auto-installer SMF start method, auto-install) > > testing done: > ------------- > [1] Distribution Constructor tested with modified transfer module > > [2] Sparc & x86 AI images built (based on 111) > verified for both x86 & Sparc that > > * ssh access is available if 'livessh=enable' provided in > install configuration file > > * logging service verbose level set to LS_DBGLVL_INFO > if 'install_debug=enable' provided in install > configuration file > > * pkg commands are run in verbose mode (with '-v' option) > if 'install_debug=enable' provided in install > configuration file > > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/caiman-discuss/attachments/20090403/366a9973/attachment.html>
