Alok,

The changes look fine.


Alok Aggarwal wrote:
> Ethan, William,
>
> This is a code review request to undo the work
> around put in for defect 6804 (bugster CR 6817316).
>
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7788
>
> Webrev is at -
>
> http://cr.opensolaris.org/~aalok/7788/
>
> Could you please take a look at these changes?
>
> I am testing this change by verifying if a sparc
> with <2gb of memory and an x86 with <1500mb memory
> gets a swap zvol created during install. Anything
> else I should verify prior to the push?

These numbers should be 1800mb and 1300mb respectively,
and you should also test just to make sure a system with <700mb
does create a swap slice.


thanks,
-ethan

>
> Thanks,
> Alok
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to