Hi Jean, This looks pretty good. I just had a question about the the case of converting the service_data file. If a user gets the "Unable to convert" error message and then hand edits the data file to removes the offending line(s) and then reruns the conversion script, what will happen? Will things work ok if addpg is run a second time for already created services?
And one other minor thing. Maybe consider printing out the name of each install service that has been successfully converted? Sue On 04/03/09 10:23, Joseph J VLcek wrote: > Jean McCormack wrote: >> As Dave stated, this is applies to a fairly limited audience for a >> limited time. But it still should have people looking at >> it. >> >> The premise is to deal with 1 of the following situations: >> >> 1) The user is running OpenSolaris from before Sue's fix to move the >> service_data file into a file for each service. >> >> or >> >> 2) The user is running bits from after Sue's changes. >> >> In both cases the conversion is done and the old service_data or >> services/* files are removed. If there is >> corruption in the file such that it can't be parsed properly, the >> offending file is moved to /var/installadm/service_error. >> It doesn't not check to make sure the values are valid. That is beyond >> the scope here. >> >> I'm attaching the script. >> >> Jean >> >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss > > Jean, > > This looks good to me now... but as you know I've already been looking > at it with you. > > Can someone else take a look too? > > Joe > _______________________________________________ > caiman-discuss mailing list > caiman-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/caiman-discuss
