Evan,

installadm-common.sh
------------------------------------
348-353, this comment chunk needs to be updated.


setup-dhcp.sh:
----------------------
332 - Can you just print out $net in the message?
maybe replace "requested" with "$net".

335 - just a nit - does this output look any better if this line
was indented by 3 spaces?


Other than that, it looks okay.


thanks,
-ethan


Evan Layton wrote:
> Can I please get 2 reviewers for:
>
> 7148 installadm should give correct dhcp macro for the subnet
> being configured on the server
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7148
>
> 7982 7218 appears to break get_service_address()
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7982
>
> Webrev is at:
> http://cr.opensolaris.org/~evanl/7148,7982/
>
> These are pretty simple fixes. I've tested them by creating services 
> on a machine with more than one subnet and default router. I've also 
> used create-client to create macros for specific machines. I've been 
> able to do successful AI installs from these setups.
>
> Thanks!
> -evan
> _______________________________________________
> caiman-discuss mailing list
> caiman-discuss at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss

Reply via email to