Thanks for review Joe ! Jan
On 04/09/09 20:13, Joseph J VLcek wrote: > jan damborsky wrote: >> Hi Joe, >> >> >> On 04/09/09 17:18, Joseph J VLcek wrote: >>> jan damborsky wrote: >>>> Hi, >>>> >>>> could I please ask two people for reviewing changes for following >>>> blocker ? >>>> >>>> 7944 auto-install dumps core installing 2009.06 b110 on T6300 >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=7944 >>>> >>>> webrev: >>>> http://cr.opensolaris.org/~dambi/bug-7944 >>>> >>>> Thank you very much, >>>> Jan >>>> >>>> modules affected: >>>> ----------------- >>>> * libtd >>>> * liborchestrator >>>> >>>> testing done: >>>> ------------- >>>> [1] successful AI installation done on affected machine - >>>> no core dump occurred (please see bug report for details) >>>> >>>> # mount -Flofs /tmp/libtd.so.1 /usr/snadm/lib/libtd.so.1 >>>> # mount -Flofs /tmp/liborchestrator.so.1 >>>> /usr/snadm/lib/liborchestrator.so.1 >>>> # /usr/bin/auto-install -p /tmp/ai_combined_manifest.xml >>>> /tmp/ai_manifest.defval.xml validates >>>> /tmp/ai_manifest_temp_6054.xml validates >>>> /tmp/ai_combined_manifest.xml is a valid manifest >>>> Auto reboot enabled >>>> Checking any disks for minimum recommended size of 12646 MB >>>> Disk c9t201500A0B8117690d1 size listed as 15360 MB >>>> Default disk selected is c9t201500A0B8117690d1 >>>> Disk name selected for installation is c9t201500A0B8117690d1 >>>> no manifest slice information found >>>> installation will be performed from http://ipkg.sfbay/dev >>>> (opensolaris.org) >>>> installation will be performed from http://ipkg.sfbay/dev >>>> (opensolaris.org) >>>> alternate IPS authority will be http://pkg.opensolaris.org/dev >>>> (opensolaris.org) >>>> list of packages to be installed is: >>>> entire at 0.5.11,5.11-0.110 >>>> SUNWcsd >>>> SUNWcs >>>> slim_install >>>> ... >>>> Auto install succeeded. System will be rebooted now >>>> >>>> >>>> [2] TD test driver with new libtd reported correct slice >>>> information >>>> >>>> w/o fix: >>>> -------- >>>> # /opt/install-test/bin/tdmgtst -s c9t50060E8003277014d1 >>>> Caiman Target Discovery test program - Version 4 >>>> >>> Getting slices by disk name=c9t50060E8003277014d1 >>>> >>> 44 found >>>> >>>> matches slice c9t50060E8003277014d19s3 >>>> ... >>>> >>>> matches slice c9t50060E8003277014d19s2 >>>> ... >>>> >>>> matches slice c9t50060E8003277014d19s1 >>>> ... >>>> >>>> matches slice c9t50060E8003277014d19s0 >>>> ... >>>> >>>> w/ fix: >>>> ------- >>>> # mount -Flofs /tmp/libtd.so.1 /usr/snadm/lib/libtd.so.1 >>>> # /opt/install-test/bin/tdmgtst -s c9t50060E8003277014d1 >>>> Caiman Target Discovery test program - Version 4 >>>> >>> Getting slices by disk name=c9t50060E8003277014d1 >>>> >>> 4 found >>>> >>>> matches slice c9t50060E8003277014d1s3 >>>> ... >>>> >>>> matches slice c9t50060E8003277014d1s2 >>>> ... >>>> >>>> matches slice c9t50060E8003277014d1s1 >>>> ... >>>> >>>> matches slice c9t50060E8003277014d1s0 >>>> >>>> >>>> [3] regression test >>>> installation done with new libraries and LiveCD based on 110 >>>> >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >>> The changes look good Jan. >>> >>> I only have 1 small nit: >>> usr/src/lib/liborchestrator/target_discovery.c >>> +-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-=+-= >>> >>> >>> >>> Issue 1: Miner Nit with comment wording >>> >>> Suggested change from: >>> 894 * associated with given disk, something might >>> went wrong during >>> >>> Suggested change to: >>> 894 * associated with given disk, something might >>> have gone wrong during >> >> Alok recommended following change to this comment: >> >> associated with given disk, something might went wrong during >> -> >> associated with given disk, something went wrong during >> >> which I think might be better for this situation, >> since this condition shouldn't be met if everything >> works correctly. Please let me know what you think. >> >> Thank you very much for review ! >> Jan >> > > Sure that sounds good. > > Joe
