Jean McCormack wrote:
> I'd like 2 reviewers for the following:
> 7377 No working network after reboot after installing OpenSolaris on 
> Glendale
> http://defect.opensolaris.org/bz/show_bug.cgi?id=7377
> 
> Webrev:
> http://cr.opensolaris.org/~jeanm/slim_7377
> 
> Comments:
> I don't believe anymore that this is also an issue with the live_cd 
> since it doesn't
> do network installs.
> 

No, not needed for the live CD, as NWAM is run in the live CD session.

1247: It might have been simpler to use "dladm show-link -p -o 
link,state|grep up$' here.  ifconfig parsing isn't quite as reliable, 
though what you've done is OK.

1262: You shouldn't have to do this (and really, why not check for the 
directory instead?), but I guess /etc/nwam is not packaged, as far as I 
can tell.  Please file a bug against NWAM to add that directory to the 
SUNWcs package; the file really should be packaged as well, I'd think. 
Failing to package file system objects makes the system more brittle 
than it should be.

1279: Seems like you should have just put this in the try block

Dave

Reply via email to