Jean McCormack wrote: > Thanks. No need for another code review. Thanks. updated webrev just to be complete. Will push now.
sarah *** > > Jean > > Sarah Jelinek wrote: >> Jean McCormack wrote: >>> Do we want to restrict this somewhat? I introduced the bug. I >>> believe before I moved the check it was >>> checking for 5 in all cases. When I put the check under each "if" >>> clause I modified the client to 7 mistakenly. >>> So maybe changing the 7 to 5 is what is really needed? >> You are right, it was checking lt 5. It was moved so I didn't see it, >> I just assumed you added the check. I will add this check for 5 back in. >> >> sarah >> **** >>> >>> Jean >>> >>> Sarah Jelinek wrote: >>>> I need two reviewers for: >>>> >>>> 8202 cannot add x86 AI client with latest SUNWinstalladm-tools from >>>> 4/15 >>>> >>>> webrev: >>>> >>>> http://cr.opensolaris.org/~sjelinek/bug_8202/ >>>> >>>> thanks, >>>> sarah >>>> _______________________________________________ >>>> caiman-discuss mailing list >>>> caiman-discuss at opensolaris.org >>>> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >>> >> >
