Jean McCormack wrote: > perform_slim_install.c: > In log_bld_info you should be freeing tmp_file before the various returns.
D'OH you're right I did space that off... I've added free() before any returns... > line 3011: Shouldn't you be checking the return value here? Or casting > to void? > I added the (void). Thanks! -evan > Jean > > > Evan Layton wrote: >> I need two reviewers for: >> >> 7838 Log installer build number and installed software build number in >> install_log >> http://defect.opensolaris.org/bz/show_bug.cgi?id=7838 >> >> and >> >> 6810 AI image missing D-Trace toolkit >> http://defect.opensolaris.org/bz/show_bug.cgi?id=6810 >> >> Webrev: >> >> http://cr.opensolaris.org/~evanl/7838/ >> >> >> I've tested this with both an AI and slim CD image and get the proper >> output. >> >> In the log you'll see lines similar to: >> <OM Apr 15 19:14:09> Install running on: >> >> FMRI: pkg:/entire at 0.5.11,5.11-0.111:20090331T092149Z >> >> and >> >> <OM Apr 15 19:40:42> System installed with: >> >> FMRI: pkg:/entire at 0.5.11,5.11-0.111:20090415T070733Z >> >> >> Thanks, >> -evan >> _______________________________________________ >> caiman-discuss mailing list >> caiman-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/caiman-discuss >
