Hi Sanjay, thanks a lot for review - please see me response in line.
Jan Sanjay Nadkarni wrote: > > 102 - Please let the comment about editing boot menu. Its useful for > debugging issues. I have added that line. > 178 - remove install-du since you are cleaning up ;-) You are right - removed :-) > 326-336 - can you verify that this is needed with the changes for zfs > boot. I have removed all code dealing with "zpool.cache" file. That code originally took care of having etc/zfs/zpool.cache in list of files which need to be in boot archive. I have installed 91 on ZFS root and zpool.cache is not being added in filelist.ramdisk and is not part of boot archive. I have verified that after I remove it from filelist.ramdisk and update boot archive, system boots fine. I have updated webrev with all modifications - it is available at http://defect.opensolaris.org/bz/show_bug.cgi?id=2062 Could you please look at the updated version ? Thank you > > -Sanjay > > > Jan Damborsky wrote: >> Hi Sanjay, >> >> could I please ask you for reviewing the fix for following CR ? >> >> 2062 fresh install of build 89 LiveCD results in truncated menu.lst >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2062 >> >> * Webrev: >> http://cr.opensolaris.org/~dambi/bug-2062/ >> >> * Testing done: >> Fresh install of osol-0811-89.iso (primary languages) >> with modified install-finish script done. menu.lst was >> populated accordingly and newly installer Solaris instance >> booted successfully. >> >> Thank you, >> Jan >> >> >
